search

jonorthwash / ud-annotatrix

GNU General Public License v3.0
61 stars 49 forks source link

Fix table view deleting words #327

Closed diogoscf closed 5 years ago

diogoscf commented 5 years ago

Fixes #326 The problem was so simple to solve yet such a pain to figure out

diogoscf commented 5 years ago

Also sorry for the weird changes in bundle.js. It's my editor changing spacing for it to look better. The only actual change happens at line 12980

keggsmurph21 commented 5 years ago

Nice! Also don't worry about diffs for compiled files like bundle.js: they will almost always be updated between commits.

jonorthwash commented 5 years ago

Uhm, so should @diogoscf be figuring out a way to fix this without modifying bundle.js? Since we could get a new version of that any time, right?

keggsmurph21 commented 5 years ago

Nope, modifying bundle.js is totally fine

jonorthwash commented 5 years ago

Oh, so the real change is in table.js, and bundle.js is generated from that (etc.)?

diogoscf commented 5 years ago

Yes

keggsmurph21 commented 5 years ago

exactly

keggsmurph21 commented 5 years ago

in fact, almost every commit should change bundle.js. this could probably be accomplished automatically with some continuous integration tool, but it's not super important so long as someone compiles bundle.js when they make updates

jonorthwash commented 5 years ago

Okay, got it. Thanks guys!

jonorthwash commented 5 years ago

It looks like after enter is pressed, table navigation ends. Is this a regression, or was it always like this?

diogoscf commented 5 years ago

It was already like this

jonorthwash commented 5 years ago

It looks like after enter is pressed, table navigation ends. Is this a regression, or was it always like this?

Actually, only when new information is entered, not when something is changed.

jonorthwash commented 5 years ago

It was already like this

Okay, I think I'll this as another issue, and maybe GCI task.