search

jonorthwash / ud-annotatrix

GNU General Public License v3.0
61 stars 49 forks source link

Fix table view not showing dependencies #332

Closed diogoscf closed 5 years ago

diogoscf commented 5 years ago

Fixes #331 The object containing the sentence used to create the table does not contain keys the function assumed it did. This allows for proper usage of the table for editing the HEAD, DEPREL and DEPS columns

jonorthwash commented 5 years ago

This is working much better, but something still seems to be not right:

Collapsing a column of the table after text is entered in the column makes it "disappear" when the column is expanded again until new text is entered in one of the cells, in which case that text is added to the original text. Additionally, the LEMMA column doesn't seem to collapse correctly, but does exhibit this same behaviour otherwise.

jonorthwash commented 5 years ago

Actually, various columns seem to decide not to collapse, not just LEMMA.

diogoscf commented 5 years ago

That was not caused by my code, but I’ll fix it.

jonorthwash commented 5 years ago

That was not caused by my code, but I’ll fix it.

Yeah, don't worry about fixing the collapse problem (that's part of another task probably), but rather the disappearing text. Disappearing text is a closely related issue to what you were doing, so it makes sense to fix it all at once.

diogoscf commented 5 years ago

It was keeping the column-hide class after expansion on the td Also *column