Minor issues with table view

[jonorthwash]

• [x] Once the table view table has been resized, it doesn't resize automatically when the window size is adjusted. If it's desired to keep the window a particular width, there could be a "lock size" feature, but in general the default should be to resize it on window resize even if it's previously been manually resized.
• [x] Text in column headers (including the "«" characters) can't be clicked to collapse/expand the column. Text shouldn't block the collapse/expand feature.
• [x] When editing the contents of a cell, pressing Esc should probably keep the cell highlighted, but leave edit mode. Currently it leaves table navigation entirely.
• [ ] There should be a keyboard shortcut for entering table view which should also enter table navigation mode (even if table view is already enabled).
• [x] Currently table navigation mode allows you to go into cells of collapsed columns, but does not highlight those cells. It should highlight those cells (probably in a slightly different way than uncollapsed cells).
• [x] Related to the above, there should be a keyboard shortcut for expanding and collapsing the column of the currently highlighted cell.
• [x] Delete/backspace should clear the contents of a cell.

[diogoscf]

Any ideas on what the mentioned shortcuts could be?

[jonorthwash]

For table mode, something with a t maybe? I don't know what the general schema is, and there's a lot to think about in terms of conflicts: browser and OS shortcuts, entering text in the graph view, etc.

For expanding and collapsing the column, I'm not sure. Do you have any thoughts on this?

[diogoscf]

I’ll think about possible shortcuts.

• [ ] Currently table navigation mode allows you to go into cells of collapsed columns, but does not highlight those cells. It should highlight those cells (probably in a slightly different way than uncollapsed cells).

Actually it does highlight the collapsed cells for me

[jonorthwash]

Actually it does highlight the collapsed cells for me

Aha, it works in chromium for me. So this is a firefox-specific bug I guess?

[jonorthwash]

The collapsing issues still seem to be present in firefox too—things are working a lot more nicely in chromium in general.

[diogoscf]

Aha, it works in chromium for me. So this is a firefox-specific bug I guess?

I tested it in both. That’s really weird

[jonorthwash]

What version of firefox? I'm running 60.0, it seems.

[diogoscf]

That issue was actually happening when the table got rebuilt (when rebuild() was called) but it happened in chrome and firefox for me... Just in case the new commit doesn't fix the problem, I'm running 63.0.3

[jonorthwash]

So shift-- seems to do the trick?

[jonorthwash]

Or just -.

[jonorthwash]

Currently if you enter text into an empty grid cell in a collapsed, that text disappears into the grid cell (probably rightly so). Then if you try to edit it (by pressing enter), it doesn't show the text in the entry box, and the entered text seems to get concatenated to the existing text. Also, a couple times I got it to display text in a collapsed row, but I'm having trouble reproducing it.

Also, if zoom of the graph is played with (especially ctrl-0), the ability to collapse and uncollapse columns is lost until table view is deactivated and reactivated.

What's the keyboard shortcut for entering table view and table navigation?

[diogoscf]

ctrl-alt-t for entering table view and table navigation. I’ll check the other issues later

[diogoscf]

So which should the behaviour be?

1. If you try to enter text into a collapsed cell, nothing happens
2. If you try to edit a collapsed cell, the existing text appears so you can change it based on that

[jonorthwash]

Probably something like 2, except with the column expanding:

3. If you try to edit a collapsed cell, the column uncollapses and let's you edit normally.

[jonorthwash]

The shortcut ctrl-alt-t doesn't work for me; it's a window-manager-level shortcut.

[diogoscf]

Ok. It's now alt-n

[jonorthwash]

Closing this issue; remaining issues to #499.