search

jonorthwash / ud-annotatrix

GNU General Public License v3.0
59 stars 49 forks source link

Deleting deprels causes page change on Firefox. #406

Open JPJPJPOPOP opened 4 years ago

JPJPJPOPOP commented 4 years ago

Tested on Firefox 75, if I delete two deprels in a row, a page change will trigger to go back one page.

jonorthwash commented 4 years ago

Does this happen only when deleting them using the tree editing interface, or does it happen if editing in the textbox and/or grid mode too?

JPJPJPOPOP commented 4 years ago

Just in the tree editing interface.

keggsmurph21 commented 4 years ago

I'm guessing that this is because you're using Backspace to delete the deprel? If you delete one this way, the #graph widget will lose focus, and the entire window will be listening for events. In Firefox, Backspace by can be bound to "go back a page".

The most sane workaround IMO would just be to explicitly focus the #graph widget after deleting the deprel.

keggsmurph21 commented 4 years ago

@JPJPJPOPOP can you check if bf3992b fixes this for you?

JPJPJPOPOP commented 4 years ago

@keggsmurph21 I didn't, still getting the same bug.

kmurphy4 commented 4 years ago

How are you deleting the deprel?

JPJPJPOPOP commented 4 years ago

@kmurphy4 Like now if I just load the page, type up a sentence, add a deprel, then delete it, it goes back to the new tab page.