jonorthwash / ud-annotatrix

GNU General Public License v3.0
59 stars 49 forks source link

Unable make changes to html files #407

Open JPJPJPOPOP opened 4 years ago

JPJPJPOPOP commented 4 years ago

So whenever I make a change to any of the html files in /server/public/html, and then run npm run build, the files are reverted back to the original versions and the changes are removed. Do I need to make changes to some scripts before I can edit html files? @keggsmurph21

JPJPJPOPOP commented 4 years ago

So my current highly unefficient workaround is to copy the html file I'm changing (luckily I'm only changing one), then run npm run build (which will compile the js parts of my changes), then paste the changes back on the html file. Then I'm using locally served static files to test.

JPJPJPOPOP commented 4 years ago

Ah, okay. So instead of changing the html files in /server/public/html, what we actually need to change is the corresponding .ejs files in /server/views.

kmurphy4 commented 4 years ago

Ah, okay. So instead of changing the html files in /server/public/html, what we actually need to change is the corresponding .ejs files in /server/views.

Yes! The HTML files are generated from the EJS files! I'm so sorry for not getting back to you sooner on this. All of the things that get built when you npm run build are specified in gulpfile.js. In this case, the relevant bit is:

gulp.task('html',  function(done) {
  compileEJS();
  done();
});