search

jonorthwash / ud-annotatrix

GNU General Public License v3.0
63 stars 49 forks source link

add notatrix code #426

Closed ftyers closed 3 years ago

kmurphy4 commented 3 years ago

Hi @ftyers .. sorry for the long delay in getting back to you. I agree that this is the right direction for the project(s), but I don't think this change is quite enough to get everything working.

it seems to work on my system

I think the reason that it works in your case is because notatrix is still cached in your node_modules. Removing notatrix: "..." from package.json doesn't actually clear this out. If you tried removing those cached files and re-running, I'd expect you to see an error like this:

$ npm uninstall notatrix
$ npm run server

> ud-annotatrix@1.0.0 server /home/kilgore/src/jonorthwash/ud-annotatrix
> node server/app.js || ./scripts/fail-nicely.js

internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module 'notatrix'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/kilgore/src/jonorthwash/ud-annotatrix/server/upload.js:9:12)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
sh: line 1: ./scripts/fail-nicely.js: Permission denied
npm ERR! code ELIFECYCLE
npm ERR! errno 126
npm ERR! ud-annotatrix@1.0.0 server: `node server/app.js || ./scripts/fail-nicely.js`
npm ERR! Exit status 126
npm ERR! 
npm ERR! Failed at the ud-annotatrix@1.0.0 server script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kilgore/.npm/_logs/2021-04-25T22_19_27_148Z-debug.log

I'll make another PR with the changes.

keggsmurph21 commented 3 years ago

Oops^