search

jonorthwash / ud-annotatrix

GNU General Public License v3.0
59 stars 49 forks source link

when two nodes clicked in existing graph, new deprel is created overwriting existing one #502

Open jonorthwash opened 1 year ago

jonorthwash commented 1 year ago

When two nodes are clicked on the graph to create a deprel, a new deprel is created which overwrites any existing one. This results in data loss.

Perhaps it should just do nothing? It could either stay in "need to select 2nd node" mode, or return to "looking at the graph (and not editing deprels)" mode.

nschneid commented 1 year ago

Or it could request confirmation with a modal dialog ("Overwrite existing deprel?"), though that could get annoying.

Honestly the current behavior might be fine as long as it's visually salient that an old deprel is disappearing, and the undo button is available to recover if it was accidental.