jonoxia / pencilbox

An open-source touchscreen-enabled HTML5 comic drawing app with a UI that doesn't suck
8 stars 0 forks source link

Wanted: Login with BrowserId #46

Closed jonoxia closed 13 years ago

jonoxia commented 13 years ago

Use BrowserID for login: https://browserid.org/developers

(instead of the current "no login" option)

jonoxia commented 13 years ago

Mostly done in https://github.com/jonoxia/pencilbox/commit/0a40ba28ffcd3a3000a8add73e9495cc3887ae27 and https://github.com/jonoxia/pencilbox/commit/aec2ba571b1933dfc8f319105d55f195d195ac4b

Couple minor things that still need doing:

verifyId() needs to move to a common python file; save.py and load.py need to use it to make sure you're who you say you are.

when verifyId() fails, it needs to kick you out back to index.html

need a logout link that deletes the cookie

index.html should maybe send you straight to listworks.py if it sees you have a valid login cookie already

DrawingHistory entries should be keyed to artist ID, not name or email. That way we can let you change your name and/or your email without losing all your artwork.

Add UI to change name and/or email?

jonoxia commented 13 years ago

In https://github.com/jonoxia/pencilbox/commit/15eca333441b498aba4be0acd8d4d2b3e7124e95 and https://github.com/jonoxia/pencilbox/commit/20e183a4da1608e64228d9dca1444568c7c2cfb9

verify_id() moved to common python file, used for save and load, kicks you out on failure, and there's a login link that deletes the cookie. Will start new bug for the other stuff.