search

jonra1993 / fastapi-alembic-sqlmodel-async

This is a project template which uses FastAPI, Pydantic 2.0, Alembic and async SQLModel as ORM. It shows a complete async CRUD using authentication and role base access control.
MIT License
964 stars 150 forks source link

Feature Request: Rate Limiter #63

Closed jymchng closed 1 year ago

jymchng commented 1 year ago

Feature Request: Rate Limiter

Can you please help to add rate limiter to the login endpoints? Can consider using this: https://github.com/long2ice/fastapi-limiter.

Thank you.

jonra1993 commented 1 year ago

Hello @jymchng this is a really good idea I do not think login is a good sample I am going to create some sample endpoints in which can be easy to do and if you require to login just need to replicate it. What do you think?

jymchng commented 1 year ago

Hello @jymchng this is a really good idea I do not think login is a good sample I am going to create some sample endpoints in which can be easy to do and if you require to login just need to replicate it. What do you think?

Hi @jonra1993, I think that is a great idea! Yeah, maybe for some read-endpoints, these can be rate-limited. Thank you!

jonra1993 commented 1 year ago

Hello @jymchng, this has been implemented in this commit https://github.com/jonra1993/fastapi-alembic-sqlmodel-async/commit/69fcf6d7836b828e862c4cb4b35ccc21604d7dbd please check natural language apis

jymchng commented 1 year ago

@jonra1993 Thank you for this Jonathan!