jonrandahl / Umbraco-Semi-Automatic-Permissions

A semi-automatic batch file which prompts the user for the Application Pool name and sets the correct permissions to your local Umbraco install. Easy to be extended and hopefully forked and expanded upon!
2 stars 2 forks source link

Unnecessary icacls call? #1

Open creativesuspects opened 11 years ago

creativesuspects commented 11 years ago

I think this line can be left out:

icacls %1\web.config /grant "%AccessUserName%":(OI)(CI)M

Inheritance rights are only applied to directories: http://technet.microsoft.com/en-us/library/cc753525%28v=ws.10%29.aspx

So this call, which is already in the script, should suffice:

icacls %1\web.config /grant "%AccessUserName%":M

Please correct me if I'm wrong.

jonrandahl commented 11 years ago

Thanks Arjan, Those lines were in the original, both from Matt and the one on the community, I can't find any reference to why it's there so if you think it's redundant then feel free to remove it?

http://blog.mattbrailsford.com/2010/08/01/adding-a-windows-context-menu-item-to-set-umbraco-folder-permissions/ http://our.umbraco.org/wiki/install-and-setup/set-umbraco-folder-permissions-from-command-line

creativesuspects commented 11 years ago

Yeah, I noticed it in the Umbraco wiki also. But according to Microsoft's documentation it would be redundant. I'll remove it from my customized script, and I'll let you know if I encounter any issues without that line.