Separate stopMocking() into disableMocking() and stopMocking()

jonreid / OCMockito

Mockito for Objective-C: creation, verification and stubbing of mock objects

MIT License

991 stars 118 forks source link

Separate stopMocking() into disableMocking() and stopMocking() #140

Closed cerihughes closed 7 years ago

cerihughes commented 7 years ago

A PR to address the crash that happens when a mock is called from a dealloc method (and ONLY the dealloc method).

See https://github.com/jonreid/OCMockito/issues/141 for context.

coveralls commented 7 years ago

Coverage decreased (-0.07%) to 98.653% when pulling 19f76ccc6d29f025b718ed5452be354ae9e6805d on cerihughes:cerihughes/disable-mocks into 36857f090bba5921a3607606854089dfe4caf0eb on jonreid:master.

coveralls commented 7 years ago

Coverage increased (+0.006%) to 98.728% when pulling 902f967627a6c6b63a87db5631f8ccf54302f5bd on cerihughes:cerihughes/disable-mocks into 36857f090bba5921a3607606854089dfe4caf0eb on jonreid:master.

coveralls commented 7 years ago

Coverage increased (+0.006%) to 98.728% when pulling ff68fa11dd2f6a9b4785d338ae251fec1878f2cf on cerihughes:cerihughes/disable-mocks into 36857f090bba5921a3607606854089dfe4caf0eb on jonreid:master.

coveralls commented 7 years ago

Coverage increased (+0.006%) to 98.728% when pulling ae294b89e330f4f6d2285b68d00066b7ce777349 on cerihughes:cerihughes/disable-mocks into 36857f090bba5921a3607606854089dfe4caf0eb on jonreid:master.

jonreid commented 7 years ago

Thank you for your continued attention to this subtle problem! I appreciate your thorough explanations, and failing test cases SO MUCH.