jonsamwell / angular-http-batcher

Enables HTTP batch request with AngularJS
MIT License
96 stars 28 forks source link

Client Cache Support? #15

Closed sarg3nt closed 3 months ago

sarg3nt commented 9 years ago

I noticed that the auto batcher does not seem to support client cached calls. Is there a plan to implement this in the future? I was just noodling it over and am not sure what the best method would be. I don't know how you would tell that a previous request has cache headers set. I've Googled it very quickly and haven't found much. Any thoughts?

Totally a low priority. I'm currently working on a sprint item for our new website to investigate the caching of ajax requests and noticed they don't work with auto batcher. I'd rather use auto batcher then have them cached so not a super huge deal but would like to have accurate information to get back to the team to. So, let me know what your thoughts are.

jonsamwell commented 9 years ago

Yes this is interesting. Let me have a play. It would be good that if you set cache to true in your $http request the batcher would not send this request if it has already been cached. On 29 Apr 2015 08:08, "dsargent3220" notifications@github.com wrote:

I noticed that the auto batcher does not seem to support client cached calls. Is there a plan to implement this in the future? I was just noodling it over and am not sure what the best method would be. I don't know how you would tell that a previous request has cache headers set. I've Googled it very quickly and haven't found much. Any thoughts?

Totally a low priority. I'm currently working on a sprint item for our new website to investigate the caching of ajax requests and noticed they don't work with auto batcher. I'd rather use auto batcher then have them cached so not a super huge deal but would like to have accurate information to get back to the team to. So, let me know what your thoughts are.

— Reply to this email directly or view it on GitHub https://github.com/jonsamwell/angular-http-batcher/issues/15.