search

jonsamwell / angular-http-batcher

Enables HTTP batch request with AngularJS
MIT License
96 stars 28 forks source link

setAllowedBatchEndpoint ignores enabled #21

Closed benripley closed 9 years ago

benripley commented 9 years ago

When sending enabled: false to setAllowedBatchEndpoint, the requests are still being sent via a batched request.

var batchOptions = {
  ignoredVerbs: ['head', 'put', 'post', 'delete'],
  enabled: false
};
batchConfigProvider.setAllowedBatchEndpoint('/api', '/batch', batchOptions);

// batch requests are enabled...
jonsamwell commented 9 years ago

This is odd I have a few tests that cover this functionality? I'll look into it.

jonsamwell commented 9 years ago

Sorry - I'll get around to this tonight.

benripley commented 9 years ago

Don't hurry on my account. It's quite easy to work around. I just thought you'd want to know.

Thanks, Ben

On Mon, Aug 10, 2015 at 7:43 AM, Jon Samwell notifications@github.com wrote:

Sorry - I'll get around to this tonight.

— Reply to this email directly or view it on GitHub https://github.com/jonsamwell/angular-http-batcher/issues/21#issuecomment-129418004 .

jonsamwell commented 9 years ago

Hi @benripley,

What version of the library are you using as I can't reproduce this?

Thanks,

Jon

benripley commented 9 years ago

Sorry. Looks like I had an old version. 1.2.0. I'll try this on the latest and let you know.

benripley commented 9 years ago

Sorry about that Jon. Wasn't aware that I had an old version. Closed.

jonsamwell commented 9 years ago

No worries!