search

jonsamwell / angular-http-batcher

Enables HTTP batch request with AngularJS
MIT License
96 stars 28 forks source link

Update httpAdapter.js #25

Closed tiwariarvin closed 9 years ago

tiwariarvin commented 9 years ago

Use encodeURI to process query strings with spaces and other such characters. batchBody.push(request.method + ' ' + encodeURI(urlInfo.relativeUrl) + ' ' + constants.httpVersion);

jonsamwell commented 9 years ago

@tiwariarvin great spot and thanks for the PR. Again could you add a simple test to prove functionality.

jonsamwell commented 9 years ago

I'll sort the test out so thanks for the PR!

jonsamwell commented 9 years ago

This fix is now in the new release (v1.11.3). Here is the test I added for it https://github.com/jonsamwell/angular-http-batcher/blob/master/tests/services/adapters/httpAdapter.spec.js#L123

tiwariarvin commented 9 years ago

Thanks Jonsamwell, Sorry that could not include test as was occupied with work for a product we are wrapping up.

Cheers Arvin