search

jonsamwell / flutter_simple_dependency_injection

A super simple dependency injection implementation for flutter that behaviours like any normal IOC container and does not rely on mirrors
MIT License
94 stars 8 forks source link

Optimized code in injector and added a possibility for method chaining #15

Closed ova2 closed 4 years ago

ova2 commented 4 years ago

We use a fork of your great library with some patched code which I now committed in this PR. All tests are green.

Thanks for accepting this PR in advance. I would be happy if you could release a new version of this lib.

jonsamwell commented 4 years ago

Thanks for this, the code looks good. I'll have a bit of time to merge this in tomorrow and do a new release.

Is this test still passing?

https://github.com/jonsamwell/flutter_simple_dependency_injection/blob/master/test/flutter_simple_dependency_injection_test.dart#L199

ova2 commented 4 years ago

Yes, test is still passing of course. Many thanks too!

Jon Samwell notifications@github.com schrieb am Fr., 23. Okt. 2020, 10:40:

Thanks for this, the code looks good. I'll have a bit of time to merge this in tomorrow and do a new release.

Is this test still passing?

https://github.com/jonsamwell/flutter_simple_dependency_injection/blob/master/test/flutter_simple_dependency_injection_test.dart#L199

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jonsamwell/flutter_simple_dependency_injection/pull/15#issuecomment-715193478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF3KZS6DRLWKZLOIGWAJPDSME6QPANCNFSM4SZYMHJQ .

ova2 commented 4 years ago

@jonsamwell I've updated this pull request. The Injector class has a factory constructor now. An Injector instance can be instantiated more shorter. "Injector.getInjector()" is marked as deprecated as discussed here https://github.com/jonsamwell/flutter_simple_dependency_injection/issues/16

I've updated CHANGELOG too.

Looking forward for a new release!

jonsamwell commented 4 years ago

@ova2 many thanks for this PR. Released as version 1.0.4

ova2 commented 4 years ago

@jonsamwell Many thanks for release too.