search

jonschlinkert / copy

Copy files using glob patterns. Sync, async, promise or streams. (node.js utility)
MIT License
94 stars 125 forks source link

Add `copy-cli` for Windows. Fixes #13 #16

Closed gsantiago closed 7 years ago

gsantiago commented 7 years ago

The CLI for this package doesn't work properly in Windows. The reason is very simple: Windows already has a copy command.

Since NPM doesn't override the command, we can't use the CLI from this package. Each time we run "copy" we will actually run the native "copy" command.

The native copy works fine in some situations, but not with globs. (See #13)

The solution I find to this is the same used by Sindre Sorhus in his del-cli package.

Since "del" is a native Windows command too, he created a new alias for the CLI usage: del-cli.

I thought we could use the same solution for this package, and make copy-cli available for those who unfortunately have to use Windows.

I hope you accept it. Thank you!

jonschlinkert commented 7 years ago

Thanks! I'll review asap!

didiergbenou commented 5 years ago

Hey @jonschlinkert , You forgot to include this in the readme for Windows users. I worked my ass off to find it lol.

seiyria commented 4 years ago

Wanted to +1 that this wasn't in the readme.