search

jonschlinkert / copy

Copy files using glob patterns. Sync, async, promise or streams. (node.js utility)
MIT License
94 stars 125 forks source link

refactor #6

Closed jonschlinkert closed 8 years ago

jonschlinkert commented 8 years ago

@doowb please review when you have a chance. I created "recurse" methods in lib/ that aren't used yet, and I might just get rid of them but the plan was to expose copy.dir methods. thoughts?

doowb commented 8 years ago

Reviewing now.

doowb commented 8 years ago

@jonschlinkert looks good :shipit:.

You might be able to use async.map instead of async.reduce in a couple of places, but that's just an optimization (depending on which is faster).

doowb commented 8 years ago

Played around with passing in some different options in the examples and things seem to just work as expected :grinning:

jonschlinkert commented 8 years ago

things seem to just work as expected

nice! good to hear. should we publish?

doowb commented 8 years ago

should we publish?

Yeah

tunnckoCore commented 8 years ago

For me also looks good. :+1: