search

jonschlinkert / git-username

Extract the username from a git remote origin URL.
https://github.com/jonschlinkert
MIT License
18 stars 3 forks source link

Support ssh formatted git urls #2

Closed jamo closed 7 years ago

jamo commented 7 years ago

It seems that current version of git-username doesn't support git repos where it's cloned over ssh and the origin url is in following format: git@github.com:${USER}/{REPO}.git

leo commented 7 years ago

We need this in release. Hope we can get this merged and released as a patch soon.

Thanks, guys! 😊

jonschlinkert commented 7 years ago

Thanks @jamo.

@leo, I'm about to publish, but wanted to clarify what you meant about releasing as a patch. Normally I would bump the minor for something like this. Is there a reason to do a patch? Are we considering this a bug, or a feature? I can see the logic in either I suppose.

leo commented 7 years ago

@jonschlinkert You're correct, of course. I just skipped the PR title and thought it's just a fix for our problem, because @jamo sent it to me. Whatever, it's a minor change!

jonschlinkert commented 7 years ago

done! thanks everyone

leo commented 7 years ago

✔️ https://github.com/zeit/release/commit/355eb22bc75ccc0abe6495f9ee6824cf5c9f2ce3

jonschlinkert commented 7 years ago

how did you release so fast?! jk lol nice work on release, great lib

leo commented 7 years ago

@jonschlinkert Thanks! 😊