jonschlinkert / gray-matter

Smarter YAML front matter parser, used by metalsmith, Gatsby, Netlify, Assemble, mapbox-gl, phenomic, vuejs vitepress, TinaCMS, Shopify Polaris, Ant Design, Astro, hashicorp, garden, slidev, saber, sourcegraph, and many others. Simple to use, and battle tested. Parses YAML by default but can also parse JSON Front Matter, Coffee Front Matter, TOML Front Matter, and has support for custom parsers. Please follow gray-matter's author: https://github.com/jonschlinkert
https://github.com/jonschlinkert
MIT License
3.91k stars 138 forks source link

Add Generic Data Typing for matter Frontmatter Parsing #168

Open emadbaqeri opened 10 months ago

emadbaqeri commented 10 months ago

The matter function currently returns a GrayMatterFile<string>, which loses type information about the expected data shape.

It would be better to allow passing a generic type parameter for the data property, like this:

interface PostMetadata {
  title: string;
  description: string;
}

declare function matter<T>(content: string): GrayMatterFile<string, T>;

const file = matter<PostMetadata>(`markdown string`); 

file.data.title; // typed as string

This way consumer code could get type safety when accessing the metadata.

For example in my case I'm parsing MDX files that expect title and description in the frontmatter. With generic data types I could get code completion and validation for those fields.

Potentially the GrayMatterFile type could be updated to add a second generic parameter:

interface GrayMatterFile<TContent, TData> {
  content: TContent;
  data: TData;   
  // ...
}

Please let me know your idea, and even let me know if I can do this in the current version of the lovely gray-matter.

emadbaqeri commented 10 months ago

I should mention that I'm doing a type casting using as and this doesn't make me happy but it does the job.

type Content = GrayMatterFile<string> & {
  data: { title: string, description: string }
}
const content = parsedContent as Content
ardunster commented 9 months ago

I would enjoy a similar feature. As is, I'm just assigning a new object from my file parsing function using just the fields I expect, and returning that, but being able to specify the type on the return from matter() would be super handy.

ardunster commented 9 months ago

Actually, it looks like this issue has been brought up before, and has been open for a long time with no feedback from the library author. Kind of disappointing. https://github.com/jonschlinkert/gray-matter/issues/135

jrock2004 commented 5 months ago

I am trying to find where but someone posted this code snippet and its made my life easier

import matter from 'gray-matter';

const typedMatter = <T = any>(markdown: string) => {
  const rawMatter = matter(markdown);

  return {
    ...rawMatter,
    data: rawMatter.data as T,
  };
};

export default typedMatter;