search

jonschlinkert / gray-matter

Smarter YAML front matter parser, used by metalsmith, Gatsby, Netlify, Assemble, mapbox-gl, phenomic, vuejs vitepress, TinaCMS, Shopify Polaris, Ant Design, Astro, hashicorp, garden, slidev, saber, sourcegraph, and many others. Simple to use, and battle tested. Parses YAML by default but can also parse JSON Front Matter, Coffee Front Matter, TOML Front Matter, and has support for custom parsers. Please follow gray-matter's author: https://github.com/jonschlinkert
https://github.com/jonschlinkert
MIT License
3.97k stars 138 forks source link

Should js-yaml be loaded via NPM? #18

Closed Ajedi32 closed 9 years ago

Ajedi32 commented 9 years ago

I noticed that a minified version of js-yaml seems to be included in this project's lib/ directory. Shouldn't that dependency be pulled in via npm instead?

jonschlinkert commented 9 years ago

it's minified to keep load times as fast as possible since js-yaml includes a lot of unnecessary files in the npm releases. it's updated by a build step https://github.com/jonschlinkert/gray-matter/blob/master/gulpfile.js#L22. however, we recently did a pr to reduce the number of files in the releases, so it might be okay to start requiring it in again. if you'd like to do a pr I'd be happy to accept as long as all tests still pass. thanks

Ajedi32 commented 9 years ago

Okay, I'll give it a shot.