Lock down coffee-script to remove error being thrown in 1.12.8

jonschlinkert / gray-matter

Smarter YAML front matter parser, used by metalsmith, Gatsby, Netlify, Assemble, mapbox-gl, phenomic, vuejs vitepress, TinaCMS, Shopify Polaris, Ant Design, Astro, hashicorp, garden, slidev, saber, sourcegraph, and many others. Simple to use, and battle tested. Parses YAML by default but can also parse JSON Front Matter, Coffee Front Matter, TOML Front Matter, and has support for custom parsers. Please follow gray-matter's author: https://github.com/jonschlinkert

https://github.com/jonschlinkert

MIT License

3.97k stars 138 forks source link

Lock down coffee-script to remove error being thrown in 1.12.8 #57

Closed aljopro closed 6 years ago

aljopro commented 7 years ago

coffee-script 1.12.8 is causing an error. To suppress the error we should lock down coffee-script to 1.12.7 until the error is resolved.

aljopro commented 7 years ago

@jonschlinkert An update to coffeescript is causing clean dev installs to fail. It's ultimately an issue on the coffeescript repo side but to get things working I've locked down the version of coffeescript in this PR. See https://github.com/jashkenas/coffeescript/issues/4805

julkue commented 7 years ago

Should work now @aljopro, due to this fix: https://github.com/jashkenas/coffeescript/issues/4805#issuecomment-348237307

jonschlinkert commented 7 years ago

since this was fixed, is there still a reason to merge this? thanks for the pr

aljopro commented 7 years ago

@jonshlinkert only if you want to move to the preferred coffee script repo. Or you can wait to do this when you have a more substantial update. Your choice.