search

jonschlinkert / is-number

JavaScript/Node.js utility. Returns `true` if the value is a number or string number. Useful for checking regex match results, user input, parsed strings, etc.
https://github.com/jonschlinkert
MIT License
256 stars 48 forks source link

benchmark misstake? #30

Open jimmywarting opened 3 years ago

jimmywarting commented 3 years ago

https://github.com/jonschlinkert/is-number/blob/98e8ff1da1a89f93d1397a24d7413ed15421c139/benchmark/index.js#L83

Think val should be named num

Same thing with https://github.com/jonschlinkert/is-number/blob/98e8ff1da1a89f93d1397a24d7413ed15421c139/benchmark/index.js#L57

jonschlinkert commented 2 years ago

yikes, good catch. A PR would be welcome, thanks for creating the issue