search

jonschlinkert / is-number

JavaScript/Node.js utility. Returns `true` if the value is a number or string number. Useful for checking regex match results, user input, parsed strings, etc.
https://github.com/jonschlinkert
MIT License
258 stars 48 forks source link

Please merge the pull requests #35

Open theUpsider opened 2 years ago

theUpsider commented 2 years ago

Dear author, this library has 69 million weekly downloads. Please merge the optimization pull requests.

jacobStankaitis commented 1 year ago

this dude denied an optimization request for is-odd or is-even package because of his ego, i don't think it's going to happen

atridadl commented 1 year ago

Why is anyone trying to ask for changes? Just use primitives and stop using dependencies for simple things.

M-Valentino commented 9 months ago

Why is anyone trying to ask for changes? Just use primitives and stop using dependencies for simple things.

 "node_modules/to-regex-range": {
      "version": "5.0.1",
      "resolved": "https://registry.npmjs.org/to-regex-range/-/to-regex-range-5.0.1.tgz",
      "integrity": "sha512-65P7iz6X5yEr1cwcgvQxbbIw7Uk3gOy5dIdtZ4rDveLqhrdJP+Li/Hx6tyK0NEb+2GCyneCMJiGqrADCSNk8sQ==",
      "dependencies": {
        "is-number": "^7.0.0"
      },

This was in a package-json of mine. eslint-config-next uses is-number in a deeply nested dependency. ESLint might run 0.1% faster if the optimization was implemented.

2ndwolf commented 6 months ago

This module makes me feel hostile and comes from dependency HELL, especially considering it has been unmaintained for 6 YEARS and is still extremely highly used.

I get it does type safety on js and devs will feel safer using this module. That such a simple thing shouldn't need to be maintained... but the author of this thing ignores people trying to make his somehow de facto super important module better.

Why is the author creating straightforward but popular modules only to ignore its users? Is there an intent of watching the world burn? Did they create too many straightforward modules to keep up maintaining them? Was that just some kind of way to get visibility which backfired due to being way more popular than expected?

At this point, maybe npm should hunt down modules like this one; confiscate and place them in actively maintained repos.

P.S.: I wrote this because is-odd came back to mind as a stupidly straightforward thing that has a module and was appaled by the fact the author of these just doesn't care. Just checked my node_modules folder and... behold, I have is-number somehow as a deeply nested dependency of ts-loader which I need with webpack.

P.P.S.: of the 73M weekly downloads of is-number, 62M of them seem to come from usage of to-regex-range.... hmm