Open pi0 opened 6 years ago
Node 0.x is failing because of usage of const
in tests. Should we keep it?
Should we keep it?
I don't feel strongly either way, but I think it's okay if we drop support for Node.js 0.x. Thoughts?
Thanks for doing this!
@jonschlinkert Friendly reminder about this PR :D
Can't believe I forgot about this PR for so long. Sorry @pi0! Before I merge, did you want to update the main export to use the function that was fastest in benchmarks? The current function did pretty well, so I'm fine with either way.
NP @jonschlinkert. Sure will update branch 😊
Hi! I've added 3 new variants to the benchmarks:
oneTypeof
,oneLiner
andtwoLiner
.Results
All tests was runned on MacBook Pro / 10.14. It seems that
twoLiner
is the winner in all runs.Node 8
Run 1:
Run 2:
Node 10
Run 1:
Run 2: