performance, benchmarks

jonschlinkert / kind-of

Get the native JavaScript type of a value, fast. Used by superstruct, micromatch and many others!

https://github.com/jonschlnkert

MIT License

347 stars 38 forks source link

performance, benchmarks #1

Closed tunnckoCore closed 9 years ago

tunnckoCore commented 9 years ago

Aloha! Please run benchmarks on your side and change them, Im curios :P

add 1-2 possible cases in old tests
add tests for es6 features and check if tests run on es6
reorder the checks to increase performance, miss something or im right?
add more benchmarks
add mocha as dev dep, lol its misses

jonschlinkert commented 9 years ago

thanks! pulling down now

tunnckoCore commented 9 years ago

@jonschlinkert so, to revert it back or you will do this?

tunnckoCore commented 9 years ago

@jonschlinkert done

jonschlinkert commented 9 years ago

k I'll get this merged after you add the Array.isArray() fallback, unless you want me to merge and do another pr. your call

tunnckoCore commented 9 years ago

k, I'll do.

tunnckoCore commented 9 years ago

@jonschlinkert ping-poke :)

tunnckoCore commented 9 years ago

omg

jonschlinkert commented 9 years ago

I merged your code, it's fine. everything is updated.

jonschlinkert commented 9 years ago

I was looking for a better solution for toggling es6 features in tests. the conditional code you put doesn't work

tunnckoCore commented 9 years ago

I merged your code, it's fine. everything is updated.

you merged that pr? rly? lol, look again https://github.com/tunnckoCore/kind-of/blob/master/index.js

test solution, yea, i tried it https://travis-ci.org/tunnckoCore/kind-of/builds/60972693

tunnckoCore commented 9 years ago

you merged the another PR that we conclude to include in this with https://github.com/tunnckoCore/kind-of/commit/b37866693129734e63e5f471abf82780c22a3304

tunnckoCore commented 9 years ago

:dolls: doh , i dont know, there's no logic... to enter in the if.

jonschlinkert commented 9 years ago

this is getting updated to your pr

tunnckoCore commented 9 years ago

@jonschlinkert

License objects and a "licenses" property containing an array of license objects are now deprecated from npm@v2.10+

https://docs.npmjs.com/files/package.json#license http://npm1k.org/

jonschlinkert commented 9 years ago

resolved by https://github.com/jonschlinkert/kind-of/commit/ac83fa3b3b4425140514e3a7a0e5534f93ec7648

tunnckoCore commented 9 years ago

hmm cool. but object always would be most slowest... i think it's not a good idea to be at the end - it is in "most common use-cases", imo

jonschlinkert commented 9 years ago

in "most common use-cases", imo

so, you're saying you would use a generalized library for something specific? e.g. I personally would use is-object or is-plain-object

tunnckoCore commented 9 years ago

oh.. yea, you're right. im sleepy. :stars: