search

jonschlinkert / kind-of

Get the native JavaScript type of a value, fast. Used by superstruct, micromatch and many others!
https://github.com/jonschlnkert
MIT License
347 stars 38 forks source link

add support for `Error` type? #20

Closed ianstormtaylor closed 6 years ago

ianstormtaylor commented 6 years ago

Hey @jonschlinkert, awesome util!

Would you consider adding support for the native Error constructor checking, for an 'error' type string?

jonschlinkert commented 6 years ago

Would you consider adding support for the native Error constructor checking, for an 'error' type string?

Hey @ianstormtaylor, thanks! Do you mean something different than the current error check? I'm open to anything that will improve the lib if you want to do a PR.

ianstormtaylor commented 6 years ago

Ah wow I'm dumb, I read the readme and assumed it wasn't there. Just added a PR for the readme addition. Thank you!

jonschlinkert commented 6 years ago

Not your fault! You shouldn't have to read the code to figure that out, thanks for the PR!