search

jonschlinkert / kind-of

Get the native JavaScript type of a value, fast. Used by superstruct, micromatch and many others!
https://github.com/jonschlnkert
MIT License
347 stars 38 forks source link

Added hooks support #25

Closed ghost closed 5 years ago

ghost commented 5 years ago

Added support for hooks, meaning custom handlers can be added for passed values.

tunnckoCore commented 5 years ago

I'm not sure that I like it that way. More clear and safe is how it was in the first commits with the .register thingy.

ghost commented 5 years ago

I couldn't get the register thingy to work - it was playing hell with the tests, ill have a look again l8r

ghost commented 5 years ago

Just gimme a touch more time before closing this :+1:

tunnckoCore commented 5 years ago

Hey @jonschlinkert @doowb check out this one ;p

ghost commented 5 years ago

Check out the latest commit @jonschlinkert @tunnckoCore

ghost commented 5 years ago

Hello?

ghost commented 5 years ago

Welp, it's there if anyone wants to pull this.

ghost commented 5 years ago

@tunnckoCore Is anyone going to actually answer this - instead of reacting like an idiot?

ghost commented 5 years ago

I'd like to see some decisiveness here.

tunnckoCore commented 5 years ago

Don't push so hard. It's open source dude. I know it may sucks in such situations, but patience is the key. I glace looked over the commits before week and as i remember it's okey to me. I don't have any access to merge, publish, release and proceed. I don't know what's expected from me to do man - don't overreact - i can't do anything anyway.

If you are in hurry you still can fork and use the fork temporary.

ghost commented 5 years ago

nah knock it on the head then mate, thanks

tunnckoCore commented 5 years ago

...

ghost commented 5 years ago

nah if the owner cant even put a comment, after spending time to react to MOST comments, then it aint worth my time. good luck.

jonschlinkert commented 5 years ago

I didn't comment because I was busy widdling down the 140 other issues I had queued up before this one. This was a feature request, not a bug.

tunnckoCore commented 5 years ago

Then you definitely are not familiar with the community and how everything goes. When I started and didn't have too much to do and I expected quick responses too. I was excited and was refreshing like per 20-30 minutes - no results, and I was sad and was kinda angry and wondering what the heck is happening, is there something wrong and etc. But eventually, a few years passed and now I have tons of work to do so all this time is passing very fast.

I feel you, really, it still sucks to me too, because I have tons of issues and PRs opened out there without any response or progress. But from time to time I'm pinging and move on.

Not to mention that they are totally different things - reacting is a lot easier than writing meaningful review or comment. :D Anyway.