search

jonschlinkert / randomatic

Easily generate random strings like passwords, with simple options for specifying a length and for using patterns of numeric, alpha-numeric, alphabetical, special or custom characters. (the original "generate-password")
https://github.com/jonschlinkert
MIT License
183 stars 25 forks source link

Add typescript definitions #25

Closed sangdth closed 1 year ago

sangdth commented 5 years ago

Add typescript definitions file index.d.ts, also there were some changes to eslint config to make it work with typescript keywords.

sangdth commented 5 years ago

I realized that the file tsconfig.json is useless. I will delete it in next commit. Just wondering, is there anything else I need to do as well? Also I could pump up the version, couldn't I?

Thanks.

doowb commented 5 years ago

Thanks! I'll review this shortly.

You don't need to bump the version, that's better done after the code is merged in.

jaruszewskiG commented 5 years ago

Bump, waiting for this PR to be merged.