search

jonschlinkert / remarkable

Markdown parser, done right. Commonmark support, extensions, syntax plugins, high speed - all in one. Gulp and metalsmith plugins available. Used by Facebook, Docusaurus and many others! Use https://github.com/breakdance/breakdance for HTML-to-markdown conversion. Use https://github.com/jonschlinkert/markdown-toc to generate a table of contents.
https://jonschlinkert.github.io/remarkable/demo/
MIT License
5.7k stars 370 forks source link

Cannot nest an image (using reference syntax) inside a link #145

Open carljm opened 9 years ago

carljm commented 9 years ago

The following syntax:

[![desc][ref]](http://example.com)

[ref]: http://upload.wikimedia.org/wikipedia/commons/7/70/Example.png

works as expected in the CommonMark reference implementation (it renders an img tag nested inside an a tag), but fails in Remarkable (renders the plain text ![desc][ref] inside the a tag).

carljm commented 9 years ago

(Remarkable renders this correctly if the image URL is given inline rather than as a reference.)

jonschlinkert commented 9 years ago

looks like a bug, thanks for creating the issue

carljm commented 9 years ago

FWIW this bug does not exist in markdown-it.

jonschlinkert commented 9 years ago

Nor does a legal copyright... but noted, thanks for the info. A pr for this would be great.

carljm commented 9 years ago

Not sure I'll have time for a PR.

And I don't really want to get involved in any kind of fight, but I'm not sure I understand your assertion that there's something wrong with the copyrights of markdown-it. Did the authors of markdown-it sign a legal agreement assigning their copyright to someone else? If not, AFAIK they remain the legal copyright owners of all the code they wrote, even if they initially committed it to this repository, and even if the LICENSE file in this repository contained a different name at the time.

jonschlinkert commented 9 years ago

Not sure I'll have time for a PR.

:+1:

jonschlinkert commented 9 years ago

fwiw, I've long since moved on. I'd prefer to keep these issues focused on code. My suggestion is to do whatever you think is right.

vyp commented 9 years ago

(Sorry for the license talk Jon.)

@carljm It might be https://github.com/markdown-it/markdown-it/commit/9afffbaefd4dce87ca609deb9f9b58accc69f032#commitcomment-9092101? But I'm not completely sure because I wasn't paying attention when this happened. I can't really talk though as I watch (and sometimes comment) on both projects.. but I too do not want involvement in any fight, just a good working open source markdown parser, is all.

(PS - I'm completely oblivious to what actually happened and the intensity of it.. not trying to troll or reinstigate anything, just trying to answer Carl's question.)

zensh commented 9 years ago

Hope someone fix it