search

jonschlinkert / remarked

No longer maintained, see remarkable instead!
https://github.com/jonschlinkert/remarkable/
MIT License
6 stars 1 forks source link

Is async highlighter support really needed? #11

Closed puzrin closed 10 years ago

puzrin commented 10 years ago

https://github.com/jonschlinkert/remarked/blob/master/index.js#L48-L122

There are highlight.js and one from google (used in twitter bootstrap), both sync. I don't know, is it legacy code, and is it really needed to support async pygmentize. But attempt to do async support and async highlight breacks architecture. IMHO hihglighter shoud be in renderer, and sync libs are enougth.

jonschlinkert commented 10 years ago

completely agreed!

puzrin commented 10 years ago

Fixed in master.