jonschlinkert / remarked

No longer maintained, see remarkable instead!
https://github.com/jonschlinkert/remarkable/
MIT License
6 stars 1 forks source link

attempt to implement a laxSpacing option #13

Closed nlf closed 7 years ago

nlf commented 9 years ago

The idea here was to match the LAX_SPACING option from the sundown parser. See here.

Due to the fact that the parsing is completely different, I'm not sure that this was the exact best approach, but I went for a 1:1 translation for now.

jonschlinkert commented 9 years ago

@nlf thanks so much for the time you and for doing this, but we're releasing a new lib. I'm also very sorry that you spend your valuable time on this because I didn't clearly notify the community that this repo would no longer be maintained. I feel terrible about that.

fwiw, I hope you consider helping out with remarkable, we're super excited about it and can always benefit from having someone with these skills help out.

nlf commented 9 years ago

No worries!

I took a quick look at remarkable, and it looks promising. I'll see if I can figure out how to translate this patch over there when I have a chance.

In the mean time, do you think this feature is small enough that you could merge and publish a new version even though this module isn't maintained? I'd prefer to not have to install from git if I don't have to. I understand if you'd rather not, though.

puzrin commented 9 years ago

Remarkable is not affected by this issue. Paragraph termination rules are specified in CommonMark spec.

jonschlinkert commented 9 years ago

@nlf like @puzrin mentioned, there is no need for the pr with remarkable. It's ready to use and is more comprehensive than marked/remarked.

doowb commented 7 years ago

Closing since remarked is no longer maintained. Use remarkable instead.

Edit: oops... I thought I had access to close.

jonschlinkert commented 7 years ago

@doowb you do now! thanks!