jonschlinkert / set-value

Set nested properties on an object using dot-notation.
https://github.com/jonschlinkert
MIT License
271 stars 41 forks source link

Unable to run benchmark on Windows #44

Open seanblonien opened 2 years ago

seanblonien commented 2 years ago

Node sure how out-of-date your benchmarking package is, but it doesn't seem to want to run, something about the file globbing just not working

C:\Git\set-value\benchmark>node .
Error: ENOENT: no such file or directory, open 'C:\Git\set-value\benchmark\fixtures\*.js'
    at Object.openSync (node:fs:585:3)
    at Object.readFileSync (node:fs:453:35)
    at Benchmarked.toFile (C:\Git\set-value\benchmark\node_modules\benchmarked\index.js:66:22)
    at Benchmarked.toFile (C:\Git\set-value\benchmark\node_modules\benchmarked\index.js:118:18)
    at Benchmarked.addFile (C:\Git\set-value\benchmark\node_modules\benchmarked\index.js:173:17)
    at Benchmarked.addFiles (C:\Git\set-value\benchmark\node_modules\benchmarked\index.js:199:14)
    at Benchmarked.addFixtures (C:\Git\set-value\benchmark\node_modules\benchmarked\index.js:266:8)
    at Benchmarked.defaults (C:\Git\set-value\benchmark\node_modules\benchmarked\index.js:84:10)
    at new Benchmarked (C:\Git\set-value\benchmark\node_modules\benchmarked\index.js:48:8)
    at C:\Git\set-value\benchmark\node_modules\benchmarked\index.js:439:19 {
  errno: -4058,
  syscall: 'open',
  code: 'ENOENT',
  path: 'C:\\Git\\set-value\\benchmark\\fixtures\\*.js'
}

Would love to be able to run the benchmarks myself and potentially add some others to see how this library stacks up

Node 16.13.1 NPM 8.1.2 Tried in both Command Prompt/Git Bash shells Windows 10

EDIT: so it works on WSL, just not Windows. is there a reason why a node script (which I assume should be cross-platform) doesn't work on Windows?