search

jonschlinkert / sublime-markdown-extended

Top 100 Sublime Text plugin! Markdown syntax highlighter for Sublime Text, with extended support for GFM fenced code blocks, with language-specific syntax highlighting. YAML Front Matter. Works with ST2/ST3. Goes great with Assemble.
https://github.com/jonschlinkert
MIT License
659 stars 96 forks source link

Add syntax highlighting inside Jekyll's highlight tags, plus Kramdown support #101

Closed aldanor closed 7 years ago

aldanor commented 9 years ago

Apparently, no ST packages currently provide proper syntax highlighting inside Jekyll's code highlight blocks and inside Kramdown block attributes – this is what GitHub Pages uses so there's sure some demand for it :)

This PR adds some basic Kramdown highlighting plus source code highlighting inside highlight and endhighlight Liquid tags.

markdown-jekyll-kramdown

aldanor commented 9 years ago

Edit: I've just noticed Kramdown inline attributes were somewhat covered in #87 which hasn't been merged in yet, but I believe this version is a bit more granular.

jonschlinkert commented 9 years ago

This is great! thanks! I'll get this merged asap. I'll try tonight be it might be tomorrow.

aldanor commented 9 years ago

Changed liquid tags / kramdown block attributes highlighting to comment.block.html since the color used for meta.block-level.markdown markup.raw.block.markdown often overlaps with the normal code highlighting in many themes (e.g. see the first image in this PR). This way it's more faded out and easier to tell where the code blocks start and end.

markdown-jekyll-kramdown-2

aldanor commented 9 years ago

@jonschlinkert :wave: what do you think?

Let me know if you have any concerns re: this PR, would love to see this get merged, been using it myself with great success :)

jonschlinkert commented 9 years ago

No concerns at all, looks great, I just need a little time to use it to weed out bugs if any exist. give me a day or two.

aldanor commented 9 years ago

No worries, thanks! Looking forward to the review then

aldanor commented 8 years ago

:octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat:

^ these octocats miss syntax highlighting!

jonschlinkert commented 8 years ago

sorry it has taken so long to get back to you on this. There are some issues that I was hoping to look into but haven't had time. Here is a screen of one issue I found:

before

This is what it should look like:

screen shot 2015-10-12 at 5 49 59 am

after

This is what it looked like after enabling your changes:

screen shot 2015-10-12 at 5 51 35 am
jonschlinkert commented 7 years ago

closing based on age and no response to my last comment. I'd be happy to revisit if we can smooth out the edge cases. thanks