Closed aldanor closed 7 years ago
Edit: I've just noticed Kramdown inline attributes were somewhat covered in #87 which hasn't been merged in yet, but I believe this version is a bit more granular.
This is great! thanks! I'll get this merged asap. I'll try tonight be it might be tomorrow.
Changed liquid tags / kramdown block attributes highlighting to comment.block.html
since the color used for meta.block-level.markdown markup.raw.block.markdown
often overlaps with the normal code highlighting in many themes (e.g. see the first image in this PR). This way it's more faded out and easier to tell where the code blocks start and end.
@jonschlinkert :wave: what do you think?
Let me know if you have any concerns re: this PR, would love to see this get merged, been using it myself with great success :)
No concerns at all, looks great, I just need a little time to use it to weed out bugs if any exist. give me a day or two.
No worries, thanks! Looking forward to the review then
:octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat: :octocat:
^ these octocats miss syntax highlighting!
sorry it has taken so long to get back to you on this. There are some issues that I was hoping to look into but haven't had time. Here is a screen of one issue I found:
before
This is what it should look like:
after
This is what it looked like after enabling your changes:
closing based on age and no response to my last comment. I'd be happy to revisit if we can smooth out the edge cases. thanks
Apparently, no ST packages currently provide proper syntax highlighting inside Jekyll's code highlight blocks and inside Kramdown block attributes – this is what GitHub Pages uses so there's sure some demand for it :)
This PR adds some basic Kramdown highlighting plus source code highlighting inside
highlight
andendhighlight
Liquid tags.