search

jonschlinkert / sublime-markdown-extended

Top 100 Sublime Text plugin! Markdown syntax highlighter for Sublime Text, with extended support for GFM fenced code blocks, with language-specific syntax highlighting. YAML Front Matter. Works with ST2/ST3. Goes great with Assemble.
https://github.com/jonschlinkert
MIT License
659 stars 96 forks source link

ES6 and JSX support #104

Closed osenvosem closed 8 years ago

osenvosem commented 8 years ago

Please add ES6 and JSX support. Now it looks like: screen shot 2015-10-12 at 10 10 04 And this is Babel highlighting: screen shot 2015-10-12 at 10 10 12

jonschlinkert commented 8 years ago

sure, I can add this next time I have a chance to make edits. or would you like to do a pr?

osenvosem commented 8 years ago

@jonschlinkert I would like to with pleasure, if I had enough skills for that. Btw, I asked you to add twig support on the 12th of May. Today is the 12th of October. Such a coincidence.

tomchentw commented 8 years ago

@jonschlinkert I'd love to help out this since currently the color just breaks for JSX elements, making it very ugly and weird.

For what I can tell, I should modify some places from these code block sections: https://github.com/jonschlinkert/sublime-markdown-extended/blob/master/Syntaxes/Markdown%20Extended.sublime-syntax#L265-L279

and to change syntax highlighter to use babel. Am I correct?

nathanmarks commented 8 years ago

@tomchentw did you fork this with any luck?

jonschlinkert commented 8 years ago

I should have closed this before. the "strange coloring" is from changes in ST3, some of which seem unfixable at this level.

@tomchentw @nathanmarks fork the hell out of it. this is open source, I do this in my spare time. I'm glad people get value of the package, but every time someone makes a comment like that it makes me want to make all of my repos private.