jonschlinkert / sublime-markdown-extended

Top 100 Sublime Text plugin! Markdown syntax highlighter for Sublime Text, with extended support for GFM fenced code blocks, with language-specific syntax highlighting. YAML Front Matter. Works with ST2/ST3. Goes great with Assemble.
https://github.com/jonschlinkert
MIT License
660 stars 96 forks source link

adds support for Jekyll '{% highlight %}' codeblocks #107

Closed gkemmey closed 8 years ago

gkemmey commented 8 years ago

Jekyll has code blocks of the format:

{% highlight js %}
// cool javascript stuff
{% endhighlight %}

Jekyll uses Pygments for syntax highlighting out-of-the-box, so I don't know if all the words would match as is (i.e sql is mysql in pygments).

Anyway, I use Markdown Extended, but wanted it to also syntax highlight code when editing Jekyll blog files so this is what I've been using.

jonschlinkert commented 8 years ago

wow this is a great pr! nice work. Have you experienced any performance issue with the extra matching? it looks like there shouldn't be any problems.

gkemmey commented 8 years ago

I haven't, but I've just done some local testing on my various personal Markdown files. Any suggestions for trying something more exhaustive?

jonschlinkert commented 8 years ago

No, I wish I did lol. Would be nice if there was an easy way to run unit tests on packages. I'll pull this down asap and try to get it merged. Sorry for the delay but might be Mon. before I'll have a chance to review. thanks again!

gkemmey commented 8 years ago

No worries, my pleasure!

jonschlinkert commented 8 years ago

thanks again!