jonschlinkert / sublime-markdown-extended

Top 100 Sublime Text plugin! Markdown syntax highlighter for Sublime Text, with extended support for GFM fenced code blocks, with language-specific syntax highlighting. YAML Front Matter. Works with ST2/ST3. Goes great with Assemble.
https://github.com/jonschlinkert
MIT License
660 stars 96 forks source link

Support for inline HTML statements #36

Closed PatrickLerner closed 9 years ago

PatrickLerner commented 10 years ago

It would be great if this style could also support inline html lines much like the default markdown style that comes with Sublime Text as I like to use it quite often to include image tags with specific properties and other such nice things.

Default Markdown Syntax Style:

screen shot 2013-12-07 at 14 25 31

Current Markdown Extended Syntax Style:

screen shot 2013-12-07 at 14 25 39

jonschlinkert commented 10 years ago

Here is mine:

image

I'm not sure why yours doesn't highlight HTML. Perhaps it's the theme?

PatrickLerner commented 10 years ago

I don't think so. I completely reset everything and all I have is Package Control, the Monokai Extended style and Markdown Extended installed. No custom settings or anything and it still does not work:

screen shot 2013-12-07 at 14 56 32

It works perfectly in the normal Markdown style that comes bundled with Sublime Text 3, however.

jonschlinkert commented 10 years ago

Hmm, I'll have to dig into this. another package must be effecting highlighting

jonschlinkert commented 10 years ago

... and thanks for looking into it more!

randy3k commented 10 years ago

see this

Markdown extended is disabling html highlight and including text.html.handlebars. so, install handlebars will solve the problem.

screen shot 2014-04-04 at 3 20 49 am

PatrickLerner commented 10 years ago

I can confirm that installing handlebars makes it work for me as well. The only difference to the official Markdown definition is that it doesn't auto close tags when I type "</" anymore (e.g. typing "test</" in the default Markdown/HTML syntax scheme, inserts "b>" automatically for me, Markdown Extended doesn't.

It's a minor issue in any case. Thanks for the hint, randy3k.

randy3k commented 10 years ago

change text.html.handlebars to text.html.basic will do the job. may be we should make a pull request for this?

randy3k commented 10 years ago

i have created a PR, #52.

randy3k commented 10 years ago

Thanks Jon Schlinkert for his quick response. He has merged my PR, the latest commit should work nicely with HTML tags. :)