search

jonschlinkert / sublime-markdown-extended

Top 100 Sublime Text plugin! Markdown syntax highlighter for Sublime Text, with extended support for GFM fenced code blocks, with language-specific syntax highlighting. YAML Front Matter. Works with ST2/ST3. Goes great with Assemble.
https://github.com/jonschlinkert
MIT License
660 stars 96 forks source link

Could you add 'php'? #41

Closed karelv closed 10 years ago

ghost commented 10 years ago

I second this request.

jonschlinkert commented 10 years ago

absolutely... will do as soon as I get a chance

jonschlinkert commented 10 years ago

I added php, let me know if you have any issues

ghost commented 10 years ago

It works, thanks! Although there is a little problem but I am not sure it is related to your plugin.

For example in GitHub this is colored:

$some_php_stuff = 5;

in Sublime it is not, unless you add php tags:

<?
$some_php_stuff = 5;
?>

which breaks GitHub (sort of, check the last tag seems wrong color). From my POV the GitHub behaviour is the expected one.

jonschlinkert commented 10 years ago

Hmm, not sure but does seem strange. Thanks for posting it here. inside the code blocks all we're doing here is using whatever language definitions are already installed. so I probably would't be able to resolve the issue with this package, (I think) it would have to be resolved with the PHP language definitions you have installed on sublime text. let me know if you learn anything else