Closed phyllisstein closed 8 years ago
bah!, Sorry I just saw this! I don't know how I missed it. I just reverted the pr that caused this issue, so it should be okay now. Let me know if you still have issues with it and I'd be happy to take a pr or try to fix it myself.
Okay, I broke it. Bad timing too, I'm in the middle of trying to launch both Assemble 0.5.0 and a new framework, so it might end up being a few days before I can fix it :-(
wish I had seen this first!
Not to worry! I'm working off my fork temporarily, so I'm in no rush. It more or less works for me, I've found, but it might be better to follow the original Markdown package's habit and just eliminate the regex that I tweaked altogether so there's no lookahead. Good luck with your other projects!
I finally made the change I suggested above, ditching the lookahead regex altogether so that the highlighter will recognize something as italic as soon as the second delimiter is typed. This strikes me as better overall, since there were a number of not-so-very-edge cases that the other way missed, but of course, the extended package isn't my baby.
closing b/c I think this was solved a long time ago. If I'm missing something let's reopen or open a new issue and I'll try to get it fixed
Makes a small change to the regex for capturing italics so that things like
_A Title_, by Anne Author
are highlighted correctly.