search

jonschlinkert / sublime-markdown-extended

Top 100 Sublime Text plugin! Markdown syntax highlighter for Sublime Text, with extended support for GFM fenced code blocks, with language-specific syntax highlighting. YAML Front Matter. Works with ST2/ST3. Goes great with Assemble.
https://github.com/jonschlinkert
MIT License
660 stars 96 forks source link

Allow punctuation to follow italic markers. #47

Closed phyllisstein closed 8 years ago

phyllisstein commented 10 years ago

Makes a small change to the regex for capturing italics so that things like _A Title_, by Anne Author are highlighted correctly.

jonschlinkert commented 10 years ago

bah!, Sorry I just saw this! I don't know how I missed it. I just reverted the pr that caused this issue, so it should be okay now. Let me know if you still have issues with it and I'd be happy to take a pr or try to fix it myself.

jonschlinkert commented 10 years ago

Okay, I broke it. Bad timing too, I'm in the middle of trying to launch both Assemble 0.5.0 and a new framework, so it might end up being a few days before I can fix it :-(

wish I had seen this first!

phyllisstein commented 10 years ago

Not to worry! I'm working off my fork temporarily, so I'm in no rush. It more or less works for me, I've found, but it might be better to follow the original Markdown package's habit and just eliminate the regex that I tweaked altogether so there's no lookahead. Good luck with your other projects!

phyllisstein commented 10 years ago

I finally made the change I suggested above, ditching the lookahead regex altogether so that the highlighter will recognize something as italic as soon as the second delimiter is typed. This strikes me as better overall, since there were a number of not-so-very-edge cases that the other way missed, but of course, the extended package isn't my baby.

jonschlinkert commented 8 years ago

closing b/c I think this was solved a long time ago. If I'm missing something let's reopen or open a new issue and I'll try to get it fixed