search

jonschlinkert / sublime-monokai-extended

Extends Monokai from Soda with additional syntax highlighting for Markdown, LESS, HTML, Handlebars and more.
https://github.com/jonschlinkert
MIT License
514 stars 91 forks source link

Added highlighting to string interpolation #47

Closed AndreaCatalucci closed 7 years ago

jonschlinkert commented 9 years ago

Can you provide some screen captures, to show what this will look like to a user? I'm happy with how string interpolation is highlighted currently, I'd like to see what this looks like first. thanks!

AndreaCatalucci commented 9 years ago

Well it was not working in my case (ruby and elixir) here is a screenshot: before screen shot 2015-05-12 at 20 42 05 after screen shot 2015-05-12 at 20 38 50

jonschlinkert commented 9 years ago

it does look nice, interesting though that it still highlights on a syntax error.

jonschlinkert commented 9 years ago

I'll need to pull this down and test first, I'll report back after I have a chance to use it for it. If anyone else has any thoughts or feedback before I merge, please feel free to add comments

AndreaCatalucci commented 9 years ago

I think highlighting on syntax error is the right behavior. Possible improvement is to render just the hello word in white such as variables, but did not get the chance to do it so far.

jonschlinkert commented 7 years ago

@AndreaCatalucci some changes have been made since this pr. I'm going to close for now, but I'd be happy to re-open if this is still desired and not working.