Why the color is different from before?

[guozhenyi]

Yesterday, when I'm coding, I found the color is changed. It's a unexpected change.

[jonschlinkert]

Sorry about that, I'll look into it and see what happened.

[karolyi]

+1 for python source highlighting (and probably more too): original Monokai:

Monokai Extended:

def and class keywords are in different color. more to come, probably ...

[ParadiseDS]

+1 for php highlighting The monokai bright seems to be the origin one, but it cannot highlight under diff syntax (probably more...)

[jonschlinkert]

Yeah it shouldn't have changed. I'll revert whatever caused the issue.

[karolyi]

Package Control has upgraded Monokai Extended to 2015.12.29.22.12.53

the syntax is still not fixed

[OmeGak]

+1 for Python syntax highlight

[gerardroche]

PHP too.

At least one of the offending pr's is https://github.com/jonschlinkert/sublime-monokai-extended/pull/52

A diff between https://github.com/jonschlinkert/sublime-monokai-extended/commit/e99726ebe785dfb6352f175dd7decb363c3a05b0 and https://github.com/jonschlinkert/sublime-monokai-extended/commit/9a99355f6561c83a566b701ca30f41806c55b098

Reverting causes some big conflicts.

[karolyi]

Package Control: Upgraded Monokai Extended to 2016.01.31.22.05.34

It seems the problem is solved. thx!

[OmeGak]

Keeps looking wrong in Python in 2016.01.31.22.05.34.

[karolyi]

Interesting, mine is fixed:

[karolyi]

According to the latest merged pull request, the version installed must have fixed the issue:

https://github.com/jonschlinkert/sublime-monokai-extended/commit/6de4a667aa915cad33b8d1ec239138db42b2ca99

I suggest you doublecheck your settings.

[OmeGak]

Thanks! I realized I was using the automatically converted Monokai Extended from Sublime Linter instead, which doesn't get updated automatically. I simply had to select a color scheme from Monokai Extended ones and Sublime Linter overwrote the old one.

[jonschlinkert]

I'm going to close since it sounds like this is fixed. However, we can reopen if others report that it's not. thanks for the feedback

[ice9js]

PHP syntax highlighting still looks like it's broken to me.

[jonschlinkert]

Still? Or as a result of https://github.com/jonschlinkert/sublime-monokai-extended/issues/62?

[gerardroche]

I just checked against build 3103 back to 3095 and it is still messed up. It's broken until back to commit https://github.com/jonschlinkert/sublime-monokai-extended/commit/e99726ebe785dfb6352f175dd7decb363c3a05b0 which was ok.

[jonschlinkert]

ok good to know, thanks for the detail

[gerardroche]

This is still an issue, at least for PHP.

There are several issues.

One is that, from what I understand, the theme is generated from the .JSON-tmTheme files. I wasn't aware of this when I contributed a patch so I didn't modify those JSON files and generate the theme from them, I don't know how to do that. I edited the .tmTheme file directly.

In a later pull request my changes were overwritten, as I think many other changes were, see https://github.com/jonschlinkert/sublime-monokai-extended/pull/52

That pull request says "adds support for ~~ strike-through text" but look at the massive changes it made. It changed all kinds of things. For example, any previous changes that didn't use the JSON file to generate the theme were lost.

Look at the JSON files modifications in that pull request, they only add changes to the markup strikout, e.g.:

 +            "name": "Markup: strike", 
+            "scope": "markup.strike", 
+            "settings": {
+                "fontStyle": "", // Or add `strike`, but it doesn't support
+                "foreground": "#cc4273"
+            }
+        }, 
+        {

Then look at the changes to the tmTheme files, big sweeping changes.

Am I correct in thinking that is what caused the issue?