ST3 Build 3103 - Githubissues

jonschlinkert / sublime-monokai-extended

Extends Monokai from Soda with additional syntax highlighting for Markdown, LESS, HTML, Handlebars and more.

https://github.com/jonschlinkert

MIT License

514 stars 91 forks source link

ST3 Build 3103 #62

Open jonschlinkert opened 8 years ago

jonschlinkert commented 8 years ago

Edited (October 7, 2018): I just pushed up some changes, please see https://github.com/jonschlinkert/sublime-monokai-extended/pull/88. Let me know if this works for you, I would appreciate any feedback.

If you update to ST Build 3013, you might notice that your colors are different. This is due to changes in ST, nothing was changed in this theme.

I personally find the colors way too busy now, so I'll be making some improvements. In the meantime, if you have any feedback or preferences, please comment here. Thanks!

tunnckoCore commented 8 years ago

You may mean 3103 build? lol, no problems :D :+1: And yes, i noticed the changes earlier today, firstly not like them, but now i find logic in some of them. It's cool to color every method name when params given to it, and not color method name and color parenthesis when no params to it. Or.. i just not noticed it to now, lol.

screenshot from 2016-02-11 00-53-01

But yea, I dont like that object properties are same color as strings.

And now, currently I dont use your theme, but the things are same everywhere :)

Btw, hot discussion was opened https://github.com/sublimehq/Packages/issues/141

Cheers, Charlike.

jonschlinkert commented 8 years ago

I was able to easily fix most of the color changes. Also, since it's super easy to create new themes, and to toggle to different themes, I might just add a few different choices so that uses can have what they want.

orbitbot commented 8 years ago

Old	New

These screenshots highlight the main problems I'm having right now:

dots are red instead of white, which makes them difficult to see
object keys are highlighted the same way as strings even when not defined as such (eg. 'someString') which is confusing (even if in practice actually true for js)
the : after object keys is colored purple, which makes it difficult to see

tunnckoCore commented 8 years ago

@orbitbot it's because the new engine of sublime and won't be changed as i remember (but Jon can provide way to configure it?). see more https://github.com/sublimehq/Packages/issues/141

Actually, initially, i also don't like it, but now it seems better and okey to me.

jonschlinkert commented 8 years ago

I have fixes for a lot of these issues. I'll try to push up today

karolyi commented 8 years ago

+1, subscribing here to see when #69 gets fixed.

jonschlinkert commented 6 years ago

Please see https://github.com/jonschlinkert/sublime-monokai-extended/pull/88.