search

jonschlinkert / templates

System for creating and managing view collections, rendering, engines, routes and more. See the "dev" branch for most recent updates.
MIT License
60 stars 9 forks source link

Updated documentation around helpers #24

Closed tjbenton closed 6 years ago

tjbenton commented 7 years ago

I was trying to add helpers to a pug and I couldn't get it to work because the helper that I added kept saying it was undefined. So I tried the same code with a different language like handlebars and it worked as expected.

Then when I was poking around a little bit more I found that there was a variable that was created called helpers and in that object were the helpers I was trying to add.

mootari commented 6 years ago

@tjbenton This pull request has several issues:

  1. readme.md is a generated file and must not be edited directly. Edit .verb.md instead.
  2. The section you edited gets pulled from source code annotations. Changes need to be made there, and readme.md regenerated afterwards.
  3. Personally I'm not sure that your description adds any value to the annotation. A self-answered stackoverflow post or support issue might be better targets.
jonschlinkert commented 6 years ago

Going to close for the reasons mentioned by @mootari, but I do want you to know that I appreciate the pr and welcome more contributions in the future