search

jonsequitur / Its.Log

Get information out of your code at runtime to send it to log files, perf counters, consoles, services, sensors. Maximum flexibility and maintainability, minimum code.
Other
13 stars 10 forks source link

Target Its.Log project to both .NET Framework 4.6.2 and .NET Standard 2.0 #48

Closed weng271190436 closed 5 years ago

weng271190436 commented 5 years ago

I was trying to convert my project from .NET Framework to .NET Core 2.2. My project depends on Its.Log. There might be other people that depend on Its.Log who are considering migrating to .NET Core 2.2 so I did this pull request.

I did this in 3 steps:

  1. Reference NUnit3TestAdapter directly in all test projects because I faced the error "Test project Its.Log.Lite.Unit Tests does not reference any .NET NuGet adapter" when I am using Visual Studio 2019. Seems that not referencing any test adapter worked for versions before Visual Studio 2017 but since nowadays most people will use newer versions of Visual Studio, I referenced NUnit3TestAdapter and upgraded the NUnit version to the latest stable version.

  2. Upgrade Its.Log to new csproj format because .NET Core requires the new csproj format. After upgrading Its.Log's csproj, I found that it broke Its.Log.Monitoring and Its.Log.UnitTests if they still used the old csproj format. Therefore, I upgraded these two's csproj as well.

  3. Target Its.Log to .NET Standard 2.0 in addition to .NET Framework 4.6.2.

weng271190436 commented 5 years ago

The cloud build failed. But I believe it is due to me converting projects to the new csproj format. I believe that the cloud build is still using a version of msbuild that corresponds to Visual Studio 2015?

https://github.com/sendgrid/sendgrid-csharp/issues/482

jonsequitur commented 5 years ago

Thanks @weng271190436! I'll take a closer look when I get a chance and see about upgrading the AppVeyor build.

If you're not using Its.Log.Monitoring it's fine to remove it. It's been superseded by the much more capable Peaky project: https://github.com/peakytests.

And in favor of Its.Log.Lite I've been using PocketLogger: https://github.com/jonsequitur/pocketlogger.

weng271190436 commented 5 years ago

Thanks @weng271190436! I'll take a closer look when I get a chance and see about upgrading the AppVeyor build.

If you're not using Its.Log.Monitoring it's fine to remove it. It's been superseded by the much more capable Peaky project: https://github.com/peakytests.

And in favor of Its.Log.Lite I've been using PocketLogger: https://github.com/jonsequitur/pocketlogger.

I just removed Its.Log.Monitoring, Its.Log.Monitoring.UI, Its.Log.Monitoring.UnitTests.

Are you saying that I should remove Its.Log.Lite as well? I am not using it. I thought other people might be using it?

jonsequitur commented 5 years ago

Its.Log.Lite can be removed.