search

jonsequitur / dotnet-repl

A polyglot REPL built on .NET Interactive
MIT License
736 stars 37 forks source link

Shift + Enter / Shift + Tab doesn't;t work on Mac Monterey #50

Open Kingdom-Of-Heaven opened 2 years ago

Kingdom-Of-Heaven commented 2 years ago

I've just installed dotnet reply on my Mac Monterey 12.4. According to documentation SHIFT + Enter should start multiline nevertheless id doesn't work. Same with Shift+Tab to see last line from history it also doesn't work. Is it a bug or am I missing something?

jonsequitur commented 2 years ago

Shift+Enter does seem to be broken on Mac.

Shift+Tab doesn't show history, it's intended to navigate through completions.

If you type Console.<Tab> it cycles forward through completions and if you type Console.<Shift+Tab> it cycles backwards...

In theory. This seems to be broken on the Mac and on Windows, I'm seeing the order of the completions is wrong.

Kingdom-Of-Heaven commented 2 years ago

I agree, this is a bug hopefully dev team will fix it asap as it's annoying to work without that basics shortcuts.

DamianReeves commented 1 year ago

Any update on this? On a Mac and using F# and no Shift-Enter makes this a pain

cartercanedy commented 1 year ago

Currently I'm getting a total crash when I press Tab or Shift-Tab, Shift-Enter works for me though.

cartercanedy commented 1 year ago

Maybe this was already determined to be a dotnet interactive api bug, but debugging the dotnet interactive source is showing that the bug is in the command parser within Microsoft.DotNet.Interactive.Kernel. Not fixable here @jonsequitur

cartercanedy commented 1 year ago

I made the fix in dotnet-interactive upstream, but the tnterface has changed significantly since the package version referenced in the project file. It's going to take some work to update

jonsequitur commented 1 year ago

My understanding is this is a .NET console API bug.

@cartercanedy, can you point me to a fix that you tried in .NET Interactive?

cartercanedy commented 1 year ago

See this commit

jonsequitur commented 1 year ago

Thanks!

cartercanedy commented 1 year ago

Just confirming that the process doesn't crash after the most recent release, don't know if the issue above was also a result of the same kind of kernel crashes or smth else