search

jonsterling / racket-grit

Grit: the kernel around which a PRL forms
Other
3 stars 0 forks source link

Rename some things #16

Closed emberian closed 7 years ago

emberian commented 7 years ago

Classifiers -> Arities Base classifiers -> Sorts => -> binder $ -> plug

Closes #15

emberian commented 7 years ago

binder conflicts with one of the properties, although I don't know how properties work and can't quite tell from the docs either, whether that name is important.

emberian commented 7 years ago

Ok, I see where it's defined and some relevant docs, but still don't understand where the word "binder" was originally coming from...

jonsterling commented 7 years ago

@cmr The binder identifier was coming from this line: https://github.com/jonsterling/racket-logical-framework/blob/master/locally-nameless.rkt#L85

Maybe that one should be renamed to locally-nameless or binding-support or something along those lines.

david-christiansen commented 7 years ago

I like binding-support

emberian commented 7 years ago

Ok, the tests fail the same way as they did before. Merge? :)

jonsterling commented 7 years ago

@cmr The tests seem to succeed for me... Can you post the test failure?

jonsterling commented 7 years ago

I have a suggestion: maybe we could just say arity everywhere instead of binder! @david-christiansen @cmr

david-christiansen commented 7 years ago

arity is fine for pi in my book.

jonsterling commented 7 years ago

Ah, I'll bet ctt.rkt doesn't even build at this point; I'm going to go through and fix things up.

jonsterling commented 7 years ago

@cmr Now I think all the examples should work!

david-christiansen commented 7 years ago

We should really Travis this thing

jonsterling commented 7 years ago

@david-christiansen I agree... I don't know if we can do for free that with a private repo though. [I don't have any particular attachment to keeping the repo private, but I wasn't sure what your thoughts were on this.]

david-christiansen commented 7 years ago

Public works for me. We should probably rename the repo at that time.

jonsterling commented 7 years ago

OK, I've renamed the repository to racket-grit and made it public. We can set up travis soon!