jonsuh / hamburgers

Tasty CSS-animated Hamburgers
https://jonsuh.com/hamburgers
MIT License
7.05k stars 1.63k forks source link

SASS 2.0.0 compatibility #107

Closed loebi-ch closed 2 years ago

loebi-ch commented 3 years ago

Hello

I get the following DEPRECATION WARNING:

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($hamburger-layer-height, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
7 │       top: $hamburger-layer-height / 2;
  │            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  ╵
    node_modules\hamburgers\_sass\hamburgers\types\_elastic.scss 7:12  @import
    node_modules\hamburgers\_sass\hamburgers\hamburgers.scss 87:9      @import
    Client\app\components\menu\menu.component.scss 4:9                 root stylesheet

The error is self-explanatory, respectively you can read more here: https://sass-lang.com/d/slash-div

nstungcom commented 3 years ago

@loebi-ch There is already a PR for this issue but not merged yet, see: PR105 Hopefully @jonsuh or any contributors can merge the PR soon.

haskelcurry commented 3 years ago

@loebi-ch I'd like to point out that it's not only about Dart, it's a general SASS compatibility, that makes sense for any non-Dart framework. Could you please change the title of the issue? I hope that it'll make it more visible for the contributors @jonsuh

ianhobbs commented 2 years ago

+1 for this

verzola commented 2 years ago

+1 for this, the warnings are making the logs very messy: image

rhcarlosweb commented 2 years ago

+1 for this

lanceosborne commented 2 years ago

+1 for this

dominikager commented 2 years ago

+1 for this

Maxxa commented 2 years ago

+1

oguilleux commented 2 years ago

Please @jonsuh can you take a moment and look at this. Thank you !

jonsuh commented 2 years ago

This issue should be fixed via https://github.com/jonsuh/hamburgers/pull/105

oguilleux commented 2 years ago

Thanks a lot @jonsuh ! Will npmjs automatically update to latest version ? https://www.npmjs.com/package/hamburgers - I'd like to update my different projects.

jonsuh commented 2 years ago

@oguilleux Yes, I just cut a release which was also published on npm. It should be updated https://www.npmjs.com/package/hamburgers

julkue commented 7 months ago

While this change was with good intend, it should have been a major version. The release broke a legacy application of mine, since it used ^1.1.3 (since 2018).