search

jonswar / perl-mason

Mason 2
58 stars 20 forks source link

Replaced Class::MOP::load_class and is_class_loaded with Class::Load::load_class #21

Closed Leeft closed 10 years ago

Leeft commented 10 years ago

Hi Jon,

Just a few small changes since the Moose causes big stacktraces since the deprecation.

Lianna

noizex commented 10 years ago

Could this be the reason of stack traces flooding logs when using Mason2 with UWSGI? I silenced them because they were not fatal, just whenever Mason attempted some module load, and that module didn't exist (and it didn't have to exist it seems), it caused a trace dump in server.

Leeft commented 10 years ago

It generates massive stackdumps like:

Class::MOP::load_class is deprecated at /home/scuniverse/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/x86_64-linux/Class/MOP.pm line 76. Class::MOP::load_class("Mason::Interp") called at /home/scuniverse/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Mason/Util.pm line 39 Mason::Util::try {...} () called at /home/scuniverse/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Try/Tiny.pm line 83 ....

So yes, probably related :)

jonswar commented 10 years ago

Thanks. Releasing with this fix.

On Jan 14, 2014, at 2:54 PM, Lianna Eeftinck notifications@github.com wrote:

It generates massive stackdumps like:

Class::MOP::load_class is deprecated at /home/scuniverse/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/x86_64-linux/Class/MOP.pm line 76. Class::MOP::load_class("Mason::Interp") called at /home/scuniverse/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Mason/Util.pm line 39 Mason::Util::try {...} () called at /home/scuniverse/perl5/perlbrew/perls/perl-5.16.3/lib/site_perl/5.16.3/Try/Tiny.pm line 83 ....

So yes, probably related :)

— Reply to this email directly or view it on GitHub.