search

jonthegeek / rapid

R 'API' documents
https://rapid.api2r.org/
Other
6 stars 1 forks source link

Remove redundant security schemes #70

Open jonthegeek opened 11 months ago

jonthegeek commented 11 months ago

FEC has 3 security schemes, each of which is included in the default options, and none of which are referenced anywhere else. They're all api_key schemes. They can be whittled down to the first, most-secure one (the one that passes in header).

Definitely get rid of schemes that aren't referenced in paths nor in rapid::security_requirements. Try to also eliminate redundant ones.

jonthegeek commented 11 months ago

Note: appwrite.io:server has 4 apiKey schemes, but 2 of them are really just universal parameters (locale and "Your Project ID"), so they aren't redundant. They're only redundant if they're in the same location and have the same name (eg, two fields named "api_key" in "query"), and even then be careful to make sure!

I also just saw one that's secretly a bearer token but they tell you that in the description (apideck.com:crm), so also watch out for those!

jonthegeek commented 11 months ago

(so far FEC is the only one with this issue!)