Closed marcinjackowiak closed 9 years ago
The fix was actually pretty simple - there was a misplaced return statement. Thanks for pointing out the error!
This fix making these bugs appear again:
https://github.com/jonthornton/Datepair.js/commit/e91dcb8b87d048c3b215d7e220f2e59bd8e99cd6 https://github.com/jonthornton/Datepair.js/commit/693587afa56caf43c8d8cf3c74bcfd213acd3df8
Solutions?
Thanks! I fixed #23 again. I couldn't reproduce #26- could explain that one a bit more?
'defaultTimeDelta': null
still changes the end time.looks like the return
is missing, or moved outside. Not sure if that is the issue.
The code was throwing an error whenever bad data was entered into the time field:
Datepair.js:254 Uncaught TypeError: Cannot read property 'getTime' of null
This would then result in the bad characters not being removed and sometimes complete loss of functionality. Added
else
branch to prevent further processing when bad data was encountered.