jonthornton / Datepair.js

A javascript plugin for intelligently selecting date and time ranges, inspired by Google Calendar.
https://www.jonthornton.com/Datepair.js
358 stars 87 forks source link

Time picker not working properly. #68

Closed swapnilchinchwade closed 8 years ago

swapnilchinchwade commented 8 years ago

Selecting end time and again selecting start time does not reflect to end time of 1 hour difference.

jonthornton commented 8 years ago

I don't understand. Can you provide an example and step by step instructions to reproduce the problem?

swapnilchinchwade commented 8 years ago

If you choose start time 9AM it will set end time to 10AM , After doing this if you again change end time and then start time the result of end time of should be one hour difference, which is not displaying correct value. On 28 Feb 2016 04:23, "Jon Thornton" notifications@github.com wrote:

I don't understand. Can you provide an example and step by step instructions to reproduce the problem?

— Reply to this email directly or view it on GitHub https://github.com/jonthornton/Datepair.js/issues/68#issuecomment-189743808 .

robjens commented 8 years ago

I should have filed a ticket when I was experiencing these problems but figured out then. To me it seems it only likes id from the main, single, one and only container/parent element.

Any paired field moves to another div? Bust. Any nested element / selector? Bust.

Won't work. Anything that went beyond the examples really, found it extremely hard to get it working properly. Settings, especially time diff are quirky and I could never get it to work. But I guess it also had to do with me expecting a different behavior as to what was displayed in the end (sorry can't be more specific, I forgot :P)

Start with ensuring (and trust me, for form fields this is a big pain in the *\ if you wish to align anything properly without floats and vertical-align without blocks and then this ... comes along and demands all on the same level.... CSS nightmares) that everything is nested under 1 div and give it an id only. Nothing fancy.

Anyway, @swapnilchinchwade begin by sharing which config you are using? Simple, jQuery? Bootstrap? Show some code how you initialize and markup please. I understand the problem, just need a bit more info on the setup.

robjens commented 8 years ago

@jonthornton Maybe the documentation/examples need some work though. But these are some minors that may lead to confusion imho e.g. the mixed use of jQuery and native selectors. Assigning new Datapair() instance to a variable but not use it (I guess it can, but why).